[m-dev.] for review: new debugger command set (part 1 of 4)

Fergus Henderson fjh at cs.mu.OZ.AU
Fri Oct 2 19:57:37 AEST 1998


> *** UPDATE TEST CASES ***
> 
> tests/debugger/Mmakefile:
> 	Reenable queens. Conform to the new set of options.

> tests/debugger/*.inp:
> tests/debugger/*.exp:
> 	Update the inputs and expected outputs of the debugger test cases
> 	to use the new command set and output formats.
...
tests/debugger/Mmakefile:
> @@ -1,8 +1,8 @@
>  
> -include ../Mmake.common
> +include		../Mmake.common

I think it would be better to use a space there
rather than a tab, for consistency with all the
other `include' statements in */Mmakefile.

> +# EXTRA_CFLAGS = -g -v
> +# EXTRA_MLFLAGS = -g -v

Those two lines should either be deleted
or documented.

I didn't see any diffs for the tests/debugger/*.{inp,exp} files.
Probably the diffs for the `.exp' files are not worth reading,
but I would like to see the diffs for the `.inp' files.

Apart from that, that part ("UPDATE TEST CASES") looks fine.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh>  |  of excellence is a lethal habit"
PGP: finger fjh at 128.250.37.3        |     -- the last words of T. S. Garp.



More information about the developers mailing list