[m-dev.] for review: exposing the table data structure for benchmarking

Fergus Henderson fjh at cs.mu.OZ.AU
Tue Nov 24 13:26:41 AEDT 1998


On 24-Nov-1998, Zoltan Somogyi <zs at cs.mu.OZ.AU> wrote:
> 
> Reorganize the handling of global data structures, and expose the table
> pointers for tabled predicates to allow the tables to be reset to empty
> by hand-written C code for benchmarking purposes.

I noticed something missing from this change:
you should delete the predicate get_table/1 from library/private_builtin.m.

> compiler/table_gen.m:
> 	Use the new kind of item instead of a static variable declaration
> 	in pragma C code to hold the tabling pointer.
> 
> 	Remove lots of spaces at ends of lines, since many of these screw up
> 	paragraph commands in vi.

It would be much easier to review if the whitespace changes were done
separately.

...
> +++ continuation_info.m	1998/11/20 12:01:16
> @@ -290,17 +226,17 @@
>  
>  	%
>  	% Process the list of instructions for this proc, adding
> -	% all internal label information to the continuation_info.
> +	% all internal label information to global_data..

s/.././

Apart from that, it looked fine.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "Binaries may die
WWW: <http://www.cs.mu.oz.au/~fjh>  |   but source code lives forever"
PGP: finger fjh at 128.250.37.3        |     -- leaked Microsoft memo.



More information about the developers mailing list