[m-dev.] for review: cleanup of liveness info around calls

Zoltan Somogyi zs at cs.mu.OZ.AU
Wed Nov 11 20:03:55 AEDT 1998


> Perhaps it's just a matter of experience, but I can read unified diffs
> relatively easily, while context diffs require my full attention just
> to see what has changed.

Virtually all the time I would agree with you, and I think it would
be a good idea to replace context diffs with unified diffs for the tests.

> After trying to review the context diff, I am more convinced than
> ever that context diffs offer no advantages over unified diffs,
> and that unified diffs are easier to review.  (although in side-by-side
> context would be great).

In this particular case, the change to code_info was a rewrite; almost
no line of code in the affected submodule was unchanged. The reason I used
a context diff here is because with a context diff, once you untangle where
the regions start and end (and this time all the significant changes were
in one big region in each file), you *can* effectively put them side by side
by looking at two copies of the diff in two different windows, with
one window looking at the region from one file while the other window
looks at the corrresponding region from the other file. Perhaps you
didn't know that trick.

Gnu diff also has a --side-by-side option. I use it only rarely because
with the font sizes I use, I can't get a side-by-side diff of two 80-column
files to fit even in a full-screen-sized window, but those of you whose
default X font is 2x3 :-) may want to make more use of that option.

Zoltan.



More information about the developers mailing list