[m-dev.] for review: --stack-trace-higher-order

[Fergus Henderson]

On 02-Nov-1998, Zoltan Somogyi <zs at cs.mu.OZ.AU> wrote:
> 
> > > Index: runtime/mercury_stack_layout.h
> > 
> > There was no log message for the changes to this file.
> 
> There was, it was just the filename accidentally had a .c instead of a .h
> ending.

Ah, I see it now.

But the log message doesn't mention the changes from `String' to `ConstString'
in the stack layout struct.

> Both the original and your suggested replacements are wrong. If the test
> succeeds, then the label is not just missing stack trace info; the label
> is not in the label table *at all*.
> 
> I replaced the message with "reached unknown label"

Fine.

> > Apart from that, it looks OK, but I haven't finished reviewing the
> > changes to llds_out.m yet.
> 
> To make this easier, I append the rewritten portion, since it is much
> easier to read than the diff.

Thanks.  Actually `diff -c' format is probably best for this
change (no need to post it -- I've already obtained it).

I'm still haven't finished going through it, but I do have one comment
so far:

> compiler/llds_out.m:
>         Reorganize the way the way the initialization functions are generated,
>         by putting c_modules falling into different categories into different
>         bunches. c_module falling into the first category always have their
>         initialization code included, while those in the second category
>         have it included only if the old flag MR_MAY_NEED_INITIALIZATION
>         is set.

I think this won't have the intended effect, because the if
MR_MAY_NEED_INITIALIZATION is not set, then the initialization
functions won't be called, even if they are included.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh>  |  of excellence is a lethal habit"
PGP: finger fjh at 128.250.37.3        |     -- the last words of T. S. Garp.