[m-dev.] for review: typeclasses & tvar renaming

Fergus Henderson fjh at cs.mu.OZ.AU
Thu May 28 00:20:25 AEST 1998


On 27-May-1998, David Glen JEFFERY <dgj at cs.mu.OZ.AU> wrote:
> Hi,
> 
> Could you please review this, Fergus?
> 
> BTW, could you please make sure you look hard at the changes to typecheck.m?
> I feel that there may be a better way...

I think the way you've done it looks OK.

> @@ -503,14 +504,14 @@
>                  pred_info_set_typevarset(PredInfo1, TypeVarSet, PredInfo2),
>                  pred_info_set_constraint_proofs(PredInfo2, ConstraintProofs,
>                          PredInfo3),
> +                pred_info_set_arg_types(PredInfo3, TypeVarSet,
> +                                ArgTypes, PredInfo4),
> +                map__apply_to_list(HeadVars, InferredVarTypes, ArgTypes),

It would be clearer if you swap the order of those two goals.

Otherwise that change looks fine.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh>  |  of excellence is a lethal habit"
PGP: finger fjh at 128.250.37.3        |     -- the last words of T. S. Garp.



More information about the developers mailing list