[m-dev.] for review: interface tracing, part 2

Fergus Henderson fjh at cs.mu.OZ.AU
Fri May 15 00:23:51 AEST 1998


More later, but just one quick comment now:

On 14-May-1998, Zoltan Somogyi <zs at cs.mu.OZ.AU> wrote:
> 
> +++ runtime/mercury_trace.c	Mon May 11 12:16:01 1998
> @@ -49,7 +49,7 @@
...
> -bool	MR_trace_enabled = FALSE;
> +Word	MR_trace_enabled = FALSE;

I don't understand the rationale for that change.

> +/*
> +** MR_trace_from_full is a boolean that is set before every call;
...
> +** The initial value is set to TRUE to allow the programmer to gain
> +** control in the debugger when main/2 is called.
> +*/
> +
> +Word	MR_trace_from_full = 1;

This code too seems a bit inconsistent.
Why not `bool MR_trace_from_full = TRUE;' (like it says in the comment)?

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh>  |  of excellence is a lethal habit"
PGP: finger fjh at 128.250.37.3        |     -- the last words of T. S. Garp.



More information about the developers mailing list