[m-dev.] for review: split mercury_memory.{c,h}

Fergus Henderson fjh at cs.mu.OZ.AU
Thu May 7 21:21:50 AEST 1998


On 07-May-1998, Tyson Dowd <trd at cs.mu.OZ.AU> wrote:
> 
> Estimated hours taken: 5
> 
> Split mercury_memory.{c,h} into several files.
> 
> 
> runtime/Mmakefile:
> 	Add new files.
> 
> runtime/mercury_context.c:
> 	Add a #include "mercury_memory_handlers.h" as this module
> 	creates new zones using default_handler.
> 
> runtime/mercury_memory.c:
> runtime/mercury_memory.h:
> 	Other code (mostly code to set up the actual memory
> 	zones we use in the Mercury runtime).
> 
> runtime/mercury_memory_handlers.c:
> runtime/mercury_memory_handlers.h:
> 	Signal handlers for memory access violations.
> 
> runtime/mercury_memory_zones.c:
> runtime/mercury_memory_zones.h:
> 	The implementation MemoryZone data type.

Well, the log message looks fine.
It's a bit hard to check from the diff that
you've just moved code around rather than modifying
anything, but presuming that is the case,
I'm quite happy for you to commit this.

One thing I did notice in the review
(I think this was already present in the old code):

> void 
> init_memory_arena()
> {

should be `(void)' rather than `()'.

> void 
> init_zones()
> {

Ditto.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh>  |  of excellence is a lethal habit"
PGP: finger fjh at 128.250.37.3        |     -- the last words of T. S. Garp.



More information about the developers mailing list