[m-dev.] for review: Stack dumps -- the main course (round 2)

[Fergus Henderson]

On 07-Mar-1998, Tyson Dowd <trd at stimpy.cs.mu.oz.au> wrote:
> > Also, if you have say both MR_STACK_TRACE and SPEED defined,
> > then you will #define MR_INSERT_LABELS twice.
> > That seems a bit dodgy to me, although the various compilers
> > we have around don't seem to mind it.

> New version:
> 
> #if (!defined(SPEED) || defined(DEBUG_GOTOS)) && !defined(MR_INSERT_LABELS)
>   #define MR_INSERT_LABELS
> #endif
> 
> Or would
> 
> #if !defined(SPEED) || defined(DEBUG_GOTOS)
>   #undef MR_INSERT_LABELS
>   #define MR_INSERT_LABELS
> #endif
> 
> be better?

Actually they're both a little ugly.
I checked the standard and it allows multiple definitions of macros,
so long as they are the same.  So I guess it is not so dodgy after all.
That's just me being paranoid ;-)

> If this is ok, I think I'll commit this.

Yes, please go ahead.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>   |  "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh>   |  of excellence is a lethal habit"
PGP: finger fjh at 128.250.37.3         |     -- the last words of T. S. Garp.