for review: stack dumps.

Fergus Henderson fjh at cs.mu.OZ.AU
Wed Mar 4 15:13:26 AEDT 1998


On 04-Mar-1998, Tyson Dowd <trd at stimpy.cs.mu.oz.au> wrote:
> On 04-Mar-1998, Fergus Henderson <fjh at cs.mu.OZ.AU> wrote:
> > > --- mercury_goto.h	1998/01/06 07:05:59	1.5
> > > +++ mercury_goto.h	1998/02/19 05:21:38
> > > @@ -11,6 +11,7 @@
> > >  
> > >  #include "mercury_types.h"	/* for `Code *' */
> > >  #include "mercury_debug.h"	/* for debuggoto() */
> > > +#include "mercury_stack_trace.h"
> > >  #include "mercury_accurate_gc.h"
> > 
> > Why does mercury_goto.h need to include mercury_stack_trace.h and
> > mercury_accurate_gc.h?
> 
> Because they conditionally set MR_INSERT_LABELS and other defines.

For configuration macros such as these that depend on the
settings of other configuration macros, I think it would probably
better to set them all in mercury_conf.h; if the definitions of
configuration macros are scattered around in lots of different places,
then someone may forget to include the appropriate header files.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>   |  "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh>   |  of excellence is a lethal habit"
PGP: finger fjh at 128.250.37.3         |     -- the last words of T. S. Garp.



More information about the developers mailing list