for review: turning off intermodule stuff in the library

[Fergus Henderson]

On 03-Mar-1998, Zoltan Somogyi <zs at cs.mu.OZ.AU> wrote:
> 
> library/Mmakefile:
> 	Only turn on non-interface intermodule information flow
> 	if LIBRARY_INTERMODULE is defined.
> 
> Mmake.common.in:
> 	Turn on LIBRARY_INTERMODULE by default. It can be turned off
> 	by Mmake.{,stage.}params.

`mmake install' in the library directory would fail, messily;
it might be better to add some code to make it print out
an error message, so people don't waste time tracking down the
cause of the failure.

Also I just realized another problem with this:
some of the test cases in the tests subdirectory
explicitly pass `--intermodule-optization' or
`--transitive-intermodule-optimization' to mmc,
so these tests will fail if the `.opt' and `.trans_opt'
files have not been built.
Off-hand I can't think of a good solution to this.

> Mmake.common.in:
> +# Do we want to deal with intermodule information when building the library
> +LIBRARY_INTERMODULE = yes

It would be a good idea to add a comment here explaining why
you might want to override this.

> Index: library/Mmakefile
> +ifeq ($(LIBRARY_INTERMODULE),yes)
> +
>  INTERMODULE_OPTS = --transitive-intermodule-optimization
>  ENABLE_TERM_OPTS = --enable-termination
> -# CHECK_TERM_OPTS = --check-termination
> +CHECK_TERM_OPTS = --check-termination

I don't think the CHECK_TERM_OPTS should be enabled?

-- 
Fergus Henderson <fjh at cs.mu.oz.au>   |  "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh>   |  of excellence is a lethal habit"
PGP: finger fjh at 128.250.37.3         |     -- the last words of T. S. Garp.