[m-dev.] for review: changes to stack tracing

[Tyson Dowd]

On 10-Jun-1998, Zoltan Somogyi <zs at cs.mu.OZ.AU> wrote:
> RCS file: /home/mercury1/repository/mercury/runtime/mercury_stack_trace.c,v
> retrieving revision 1.7
> diff -u -u -r1.7 mercury_stack_trace.c
> --- mercury_stack_trace.c	1998/06/08 08:27:05	1.7
> +++ mercury_stack_trace.c	1998/06/10 11:11:50
> @@ -14,6 +14,12 @@
>  #include "mercury_stack_trace.h"
>  #include <stdio.h>
>  
> +typedef	enum {
> +	STEP_ERROR_BEFORE,
> +	STEP_ERROR_AFTER,
> +	STEP_OK
> +} MR_stack_walk_step_result;
> +

>From the coding standards:

	4.3. Typedefs

	Use first letter uppercase for each word, other letters lowercase and
	underscores to separate words. For instance, Directory_Entry. 

So this should be MR_Stack_Walk_Step_Result.

(I get this one wrong all the time).


A quick note on the meaning of "BEFORE" and "AFTER" would be good
for maintainers.

> +
> +static	MR_stack_walk_step_result MR_stack_walk_step(
> +	MR_Stack_Layout_Entry *entry_layout,
> +	MR_Stack_Layout_Entry **next_entry_layout,
> +	Word **stack_trace_sp_ptr, Word **stack_trace_curfr_ptr,
> +	const char **problem_ptr)
> +{

Should be

static MR_Stack_Walk_Step_Result
MR_stack_walk_step(MR_Stack_Layout_Entry *entry_layout,
	MR_Stack_Layout_Entry **next_entry_layout,
	Word **stack_trace_sp_ptr, Word **stack_trace_curfr_ptr,
	const char **problem_ptr)
{

Otherwise, the diff looks fine.  Thanks.

-- 
       Tyson Dowd           # "Bill Gates is a white persian cat and a monocle
                            # away from becoming another James Bond villan."
     trd at cs.mu.oz.au        # "No Mr Bond, I expect you to upgrade."
http://www.cs.mu.oz.au/~trd #                -- Dennis Miller and Terri Branch