[m-dev.] for review: bug fixes

[Fergus Henderson]

On 02-Jun-1998, Simon Taylor <stayl at cs.mu.OZ.AU> wrote:
> +++ mercury_compile.m	1998/06/01 04:15:18
> @@ -321,8 +321,16 @@
>              ; { ErrorCheckOnly = yes } ->
>                  % we may still want to run `unused_args' so that we get
>                  % the appropriate warnings
> -                globals__io_set_option(optimize_unused_args, bool(no)),
> -                mercury_compile__maybe_unused_args(HLDS21, Verbose, Stats, _)
> +                globals__io_lookup_bool_option(warn_unused_args, UnusedArgs),
> +                ( { UnusedArgs = yes } ->
> +                        mercury_compile__maybe_polymorphism(HLDS21,
> +                                Verbose, Stats, HLDS22), 
> +                        globals__io_set_option(optimize_unused_args, bool(no)),
> +                        mercury_compile__maybe_unused_args(HLDS22,
> +                                Verbose, Stats, _)
> +                ;
> +                        []
> +                )

You should document here why you need to call polymorphism
(it was documented in the log message, but the documentation
should also go in the source code).

Apart from that and my previous comments, it all looks fine.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh>  |  of excellence is a lethal habit"
PGP: finger fjh at 128.250.37.3        |     -- the last words of T. S. Garp.