[m-dev.] For review: handling one by one variable retrieval within the external debugger

[Erwan Jahier]

Fergus Henderson wrote:

> > --- mercury_trace_external.c.save     Wed Jul 29 15:10:43 1998
> > +++ mercury_trace_external.c  Wed Jul 29 16:05:59 1998
> > @@ -612,16 +619,12 @@
> >       restore_transient_registers();
> >       incr_hp(univ, 2);
> >
> > -     if ((strncmp(name, "TypeInfo", 8) == 0)
> > -         || (strncmp(name, "ModuleInfo", 10) == 0)
> > -         || (strncmp(name, "HLDS", 4) == 0)
> > -         || !MR_trace_get_type_and_value(var, NULL, &type_info, &value))
> > +
> > +     if (MR_trace_get_type_and_value_filtered(var, name, &type_info,
> > +                                                  &value))
> 
> I think there should be a `!' there.

I don't think so.

> 
> > +/*
> > +** "variables" representing the saved values of succip, hp etc,
> > +** which are the "variables" for which get_type_and_value
> > +** fails, are not of interest to the trace analyzer.
> > +** MR_trace_get_type_and_value_filtered() and MR_trace_get_type_filtered()
> > +** will succeed for theses variables.
> 
> s/succeed/fail/

ah yes. 
but the same way MR_trace_get_type_and_value should succeed for these
variables and the zoltan's comment I've moved is wrong too. right ?

> And last but of course by far the worst --
> you used the T word -- _plural_!  The horror! ;-)

Sorry, I miss this one.
 
> [I think you meant "these variables".]
probably.


-- 
R1.