[m-dev.] diff: disable typeclass tests in jump grades

David Glen JEFFERY dgj at cs.mu.OZ.AU
Tue Jul 21 17:15:59 AEST 1998


On 21-Jul-1998, Fergus Henderson <fjh at cs.mu.OZ.AU> wrote:
> On 21-Jul-1998, David Glen JEFFERY <dgj at cs.mu.OZ.AU> wrote:
> > Estimated hours taken: 1/2
> 
> Decimal, please, in case we ever want to do any automated processing of these
> numbers.
> 
> > -PROGS=  \
> > +SOURCES=        \
> >          constrained_lambda \
> >          extract_typeinfo \
> >          existential_type_classes \
> > @@ -24,6 +24,15 @@
> >          superclass_call \
> >          test_default_func_mode \
> >          typeclass_test_6
> 
> The name SOURCES should be used for `.m' files, and `PROGS' for executables.
> 
> I suggest you s/SOURCES/TYPECLASS_PROGS/g
> 
> > +# These tests are all failing in jump grades b/c we can't use static code
> > +# initialisers.
> > +ifneq "$(findstring jump,$(GRADE))" ""
> 
> The tests also fail in `fast' grades; you need to check for those too.

Okay... how about:


------------------------------------------------------------

Estimated hours taken: 0.5

Disable the typeclass tests in jump and fast grades since we cannot use static
code initialisers. I have an uncommitted partial fix to this. Unfortunately,
making it a proper fix will involve making all the initialisation code do two
passes, so I'm just disabling the tests for now.

tests/hard_coded/typeclasses/Mmakefile:
        Don't do anything in jump or fast grades.

Index: Mmakefile
===================================================================
RCS file: /home/staff/zs/imp/tests/hard_coded/typeclasses/Mmakefile,v
retrieving revision 1.7
diff -u -t -r1.7 Mmakefile
--- Mmakefile	1998/07/08 20:59:07	1.7
+++ Mmakefile	1998/07/21 07:13:49
@@ -6,7 +6,7 @@
 
 #-----------------------------------------------------------------------------#
 
-PROGS=  \
+TYPECLASS_PROGS=        \
         constrained_lambda \
         extract_typeinfo \
         existential_type_classes \
@@ -24,6 +24,25 @@
         superclass_call \
         test_default_func_mode \
         typeclass_test_6
+
+# These tests are all failing in jump and fast grades b/c we can't use static
+# code initialisers.
+
+ifneq "$(findstring asm_,$(GRADE))" ""
+    PROGS=$(TYPECLASS_PROGS)
+else
+    ifneq "$(findstring jump,$(GRADE))" ""
+        PROGS=
+    else
+        ifneq "$(findstring fast,$(GRADE))" ""
+            PROGS=
+        else
+            PROGS=$(TYPECLASS_PROGS)
+        endif
+    endif
+endif
+
+
 
 # implied_instance_missing_constraint is not yet included as there is a bug
 # stopping it from working.
------------------------------------------------------------

-- 
David Jeffery (dgj at cs.mu.oz.au) |  Marge: Did you just call everyone "chicken"?
PhD student,                    |  Homer: Noooo.  I swear on this Bible!
Department of Computer Science  |  Marge: That's not a Bible; that's a book of
University of Melbourne         |         carpet samples!
Australia                       |  Homer: Ooooh... Fuzzy.



More information about the developers mailing list