[m-dev.] For review: a change in MR_trace_event_external()

[Erwan Jahier]

(forget my previous post)


Fergus Henderson wrote:

> >       Add "MR_trace_cmd_info *cmd" in argument of MR_trace_event_external().
> 
> What's the rationale for this change?

oh I see why you didn't understand the rational for that change; I
forgot a part in my diff:

@@ -343,20 +363,55 @@
...
 			case MR_REQUEST_NO_TRACE:
-				MR_trace_cmd = MR_CMD_TO_END;
+				cmd->MR_trace_cmd = MR_CMD_TO_END;
 				

I will sent another one.

ps: this error (and the other one concerning the missing "return;") is
due to the fact I made those change quite a long time ago and I didn't
submit them at that time. Now, I try to split thoses changes into
several atomic changes and send you one by one. The reason why I didn't
tested those atomic changes is that ... nevermind, I should have made
the tests.

-- 
R1.