[m-dev.] For review: forward_move always moves

[Fergus Henderson]

Erwan Jahier, you wrote:
> 
> This is for Fergus.
> 
> I do this change because it is the way forward_move should behave
> according to Mireille Opium's specification.
> 
> 
> runtime/mercury_trace_external.c:
> 	Start to find a forward matching event from the next event rather
> 	from the current event (e.g., now forward_move(nop, nop, ..., nop)
> 	moves one event forward).

The rationale that you give in your mail should be part of the log message.

> @@ -343,20 +363,55 @@
>  				}
>  				search_data = debugger_request;
>  			        searching = TRUE;
> -				goto do_search;
> 

If you just delete the goto, then it will drop through into the next case.
You need to instead replace the `goto do_search' with a `return'.

Did you test this change?
Please make sure you test your changes before committing them.

When you've tested this change, please post a revised diff with a revised
log message.

Thanks,
	Fergus.

-- 
Fergus Henderson              | Designing grand concepts is fun;
fjh at cs.mu.oz.au               | finding nitty little bugs is just work.
http://www.cs.mu.oz.au/~fjh   | -- Brooks, in "The Mythical Man-Month".
PGP key fingerprint: 00 D7 A2 27 65 09 B6 AC  8B 3E 0F 01 E7 5D C4 3F