[m-dev.] for review: cleanup of mercury_stack_layout.h
Tyson Dowd
trd at cs.mu.OZ.AU
Wed Jul 8 17:49:53 AEST 1998
On 08-Jul-1998, Zoltan Somogyi <zs at cs.mu.OZ.AU> wrote:
>
> This is for Tyson.
>
> runtime/mercury_stack_layout.h:
> Reorder the components of this file into a sequence of submodules,
> with each submodule containing the definition of a type and all
> the macros that operate on that type. This should remind people
> that updating a type without updating the macros is not a good idea.
>
> Remove obsolete, unused and incorrect macros.
>
> Modify the conventions for the use of incomplete fragments of
> proc layout structures, so that by looking at a proc layout
> fragment, one can tell how much of it is actually present and
> meaningful. This is necessary to avoid references to fields
> that are not present or not meaningful.
>
> compiler/stack_layout.m:
> Emit data structures that conform to the new convention.
> Index: runtime/mercury_stack_layout.h
> ===================================================================
> RCS file: /home/mercury1/repository/mercury/runtime/mercury_stack_layout.h,v
> retrieving revision 1.7
> diff -u -u -r1.7 mercury_stack_layout.h
> --- mercury_stack_layout.h 1998/06/18 06:08:03 1.7
> +++ mercury_stack_layout.h 1998/07/08 07:02:57
> /*
> -** Macros to support hand-written C code.
> +** This structure records information about a procedure.
> +** The structure has three groups of fields:
> +**
> +** (1) those needed for travesing the stack;
s/travesing/traversing
> +** Group (1) is always be present and meaningful.
> +** Group (2) is be present and meaningful
delete 'be'
> +** if MR_ENTRY_LAYOUT_HAS_PROC_ID(entry) evaluates to true.
> +** Group (3) is be present and meaningful
delete 'be'
Otherwise it's fine. Thanks.
--
Tyson Dowd # There isn't any reason why Linux can't be
# implemented as an enterprise computing solution.
trd at cs.mu.oz.au # Find out what you've been missing while you've
http://www.cs.mu.oz.au/~trd # been rebooting Windows NT. -- InfoWorld, 1998.
More information about the developers
mailing list