[m-dev.] for review: Aditi [1]
Simon Taylor
stayl at cs.mu.OZ.AU
Thu Jul 9 14:25:07 AEST 1998
> The first one is that the new modules should all be
> documented in notes/compiler_design.html.
That's a bug in the log message.
> > compiler/globals.m:
> > Add a field to record whether there are any local Aditi procedures
> > in the current module.
>
> Shouldn't that be part of the module_info rather than the globals?
Yes.
> > compiler/mode_util.m:
> > Added partition_args/5 which partitions a list of arguments
> > into inputs and outputs.
>
> What about partially instantiated insts and `any' insts?
It partitions into inputs and others using mode_is_input - the comment
in mode_util.m is slightly clearer.
>> [library changes]
> I think it would be best to commit these three changes separately.
OK.
> > Added a function `mercury__load_aditi_rl_code()' which
> > throws all the RL code for the program at the database.
>
> This confused me for a bit; I presume you mean that you
> added code to *generate* code for that function?
>
Yes.
Simon.
More information about the developers
mailing list