[m-dev.] for review: enhancements to mtags script

[David Matthew Overton]

On Mon, Jul 06, 1998 at 06:25:21PM +1000, Fergus Henderson wrote:
> On 06-Jul-1998, David Matthew Overton <dmo at cs.mu.OZ.AU> wrote:
> > 
> > +		} else {
> > +		    # Works with vim or vi (vi ignores anything after the `;"').
> > +		    printf out "%s\t%s\t/^%s\$/;-;/%s/;\"\t%s%s\n",
> > +			$name, $file, $match_line, $name, $kind, $static;
> 
> The comment here is not correct.
> vi does not ignore anything after the ";".

Actually, the comment is correct -- just not very clear.  The double
quote character is the comment character in ex commands, so vi will ignore
anything after the sequence <semicolon> <double quote>.  Vim requires
tags with extra attributes to have a double quote at the end of the ex
command so that they are backwards compatible with vi.

> Instead, vi allows the thing after the 2nd tab to be an arbitrary ex command,
> or a sequence of multiple `ex' commands, seperated by semicolons.
> So the above command does a search for a line exactly matching $match_line,
> goes back one line (`-'), and then does a search for $name.
> This leaves the cursor on the matching line but puts $name in the
> string search buffer.
> 
[...]
> 
> This change should get another round of reviewing, so can you please
> send us another diff when you've addressed those comments?

Ok.

-- 
David Overton
MEngSc Student                       Email: dmo at cs.mu.oz.au     
Department of Computer Science       Web: http://www.cs.mu.oz.au/~dmo
The University of Melbourne          Phone: +61 3 9344 9159