[m-dev.] for review: Accurate garbage collection.
Tyson Dowd
trd at stimpy.cs.mu.oz.au
Thu Jul 2 16:48:25 AEST 1998
On 02-Jul-1998, Fergus Henderson <fjh at cs.mu.OZ.AU> wrote:
> On 02-Jul-1998, Tyson Dowd <trd at cs.mu.OZ.AU> wrote:
> > On 01-Jul-1998, Fergus Henderson <fjh at cs.mu.OZ.AU> wrote:
> > > Can you give a diff of that against the old mercury_deep_copy.c?
> >
> > Of course.
> >
> > --- mercury_deep_copy.c Thu Jul 2 15:07:47 1998
> > +++ mercury_deep_copy_body.h Tue Jun 30 16:14:37 1998
> ...
> > -** NOTE : changes to this function will probably also have to be reflected
> > -** in the function std_util::ML_expand() and mercury_table_any.c
>
> Isn't that still true?
> I think that comment should stay.
Because of the addition of MR_categorize_data, there is no longer any
control flow in deep_copy. There is a bit of data manipulation that
is similar in the different functions, but it is nowhere near as
similar as it once was.
So the comment isn't really very useful anymore -- chances are if
you are modifying deep_copy now you *won't* have to modify those
other functions.
That said, I'm happy for the comment to stay or go.
--
Tyson Dowd # "Bill Gates is a white persian cat and a monocle
# away from becoming another James Bond villan."
trd at cs.mu.oz.au # "No Mr Bond, I expect you to upgrade."
http://www.cs.mu.oz.au/~trd # -- Dennis Miller and Terri Branch
More information about the developers
mailing list