updated diff for trace-based primitive debugger
Fergus Henderson
fjh at cs.mu.OZ.AU
Tue Feb 3 22:46:52 AEDT 1998
Zoltan committed the following diff:
>mercury_regs.h:
...
>+/* saved_reg(save_area, n) accesses the given save area instead of fake_reg */
>+
>+#define saved_reg(save_area, n) \
>+ LVALUE_COND((n) > MAX_REAL_REG, \
>+ r(n), \
>+ save_area[virtual_reg_map[(n) - 1]])
This is buggy, because `r(n)' indirectly refers to `fake_reg'.
Also the comment would be clearer if it said
"saved_reg(save_area, n) is like virtual_reg(n), except that it ...".
Please post all non-trivial changes for review.
In the case where you have a long diff that has already been reviewed
and you are making further changes as a result of that review, please
post a diff relative to the previous diff posted.
--
Fergus Henderson <fjh at cs.mu.oz.au> | "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh> | of excellence is a lethal habit"
PGP: finger fjh at 128.250.37.3 | -- the last words of T. S. Garp.
More information about the developers
mailing list