[m-dev.] for review: Aditi

Fergus Henderson fjh at cs.mu.OZ.AU
Thu Dec 3 19:52:22 AEDT 1998


On 03-Dec-1998, Simon Taylor <stayl at cs.mu.OZ.AU> wrote:
> Aditi compilation.
...
> compiler/hlds_pred.m:
> 	Add predicates to identify Aditi procedures.
> 	Added markers `generate_inline' and `aditi_interface', which
> 	are used internally for Aditi code generation.
> 	Add an `owner' field to pred_infos, which is used for database
> 	security checks.

The log message here doesn't mention the new "indexes" field.

(Actually the plural of "index" is "indices",
but I suppose that doesn't matter.)

> compiler/rl_info.m: Code generator state.
> compiler/rl.m:Intermediate RL representation.
> compiler/rl_util: Predicates to collect information about RL instructions.
> compiler/rl_dump.m: Print out the representation in rl.m.

Could you please put the descriptions on a separate line from the
file names?  Just so that we have a consistent format for log messages.

Apart from that, the relative diff looks fine.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "Binaries may die
WWW: <http://www.cs.mu.oz.au/~fjh>  |   but source code lives forever"
PGP: finger fjh at 128.250.37.3        |     -- leaked Microsoft memo.



More information about the developers mailing list