[m-dev.] For review: coroutining changes

Fergus Henderson fjh at cs.mu.OZ.AU
Mon Dec 14 16:40:59 AEDT 1998


On 14-Dec-1998, Thomas Charles Conway <conway at hydra.cs.mu.oz.au> wrote:
> On Fri, Dec 11, 1998 at 03:02:52PM EST, Fergus Henderson wrote:
> > On 11-Dec-1998, Thomas Charles Conway <conway at hydra.cs.mu.oz.au> wrote:
> > > --- mercury_misc.h	1998/11/09 10:24:38	1.11
> > > +++ mercury_misc.h	1998/11/30 03:57:37
> > ...
> > > +#include <sys/types.h>		/* for fd_set */
> > 
> > This should be #ifdefd.
> > <sys/types.h> is not ANSI.

You didn't fix that problem.

In fact you shouldn't change mercury_misc.h at all, since MR_fd_zero
is declared in mercury_reg_workarounds.h not in misc.h.

Apart from that, it looks fine.  Thanks.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "Binaries may die
WWW: <http://www.cs.mu.oz.au/~fjh>  |   but source code lives forever"
PGP: finger fjh at 128.250.37.3        |     -- leaked Microsoft memo.



More information about the developers mailing list