[m-dev.] ODBC interface
Fergus Henderson
fjh at cs.mu.oz.au
Thu Oct 2 11:13:52 AEST 1997
Simon Taylor, you wrote:
> +#ifdef MR_USE_TRAIL
> +#define MR_IF_USE_TRAIL(x) x
> +#else /* ! MR_USE_TRAIL */
> +#define MR_IF_USE_TRAIL(x)
> +#endif /* ! MR_USE_TRAIL */
I'm not sure that the comments improve readability here.
They are just clutter that make it harder to find the real code.
I find the following a lot easier to read:
#ifdef MR_USE_TRAIL
#define MR_IF_USE_TRAIL(x) x
#else
#define MR_IF_USE_TRAIL(x)
#endif
But otherwise that looks good, please commit away!
Thanks.
--
Fergus Henderson <fjh at cs.mu.oz.au> | "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh> | of excellence is a lethal habit"
PGP: finger fjh at 128.250.37.3 | -- the last words of T. S. Garp.
More information about the developers
mailing list