[m-dev.] cvs diff: bug fixes for runtests

[Tyson Richard DOWD]

> 
> The solution you used is quite ugly:
> 
> >  	-c|--cflags)
> >  		cflag="-c '$2'"
> > -		cflagsopt="EXTRA_CFLAGS=$2"
> > +		cflagsopt="MGNUCFLAGS=$2"
> [...]
> > -mmake -k $jfactor $gradeopt "$flagsopt" "$cflagsopt" check
> > +
> > +if [ -n "$flagsopt" ] ; then
> > +	if [ -n "$cflagsopt" ] ; then
> > +		mmake -k $jfactor $gradeopt "$flagsopt" "$cflagsopt" 
> > +	else
> > +		mmake -k $jfactor $gradeopt "$flagsopt"
> > +	fi
> > +else
> > +	if [ -n "$cflagsopt" ] ; then
> > +		mmake -k $jfactor $gradeopt "$cflagsopt" 
> > +	else
> > +		mmake -k $jfactor $gradeopt 
> > +	fi
> > +fi
> > +
> 
> I suggest that you use
> 
> 		cflagsopt="EXTRA_CFLAGS='$2'"
> 
> and then use `eval', as is done for the `-c' option.

I'm not sure what you mean by this, `eval' is not used at all in
the `handle_options' or `runtests' scripts. Do you mean - don't pass
the variables in the arguments, but use eval to set them?

-- 
       Tyson Dowd           # "Well, let's just say, 'if your VCR is
                            #  still blinking 12:00, you don't
     trd at cs.mu.oz.au        #  want Linux'". 
http://www.cs.mu.oz.au/~trd #  --Bruce Perens, Debian's Fearless Leader