[m-dev.] diff: missing #include

Tyson Richard DOWD trd at cs.mu.oz.au
Tue Jul 29 16:29:07 AEST 1997


Fergus Henderson wrote:
> Tyson Richard DOWD, you wrote:
> > Here's a better fix then (I think):
> 
> Well, for style reasons the other fix is a good idea anyway...

Sure.

> >  
> > -MGNUC  = $(SCRIPTS_DIR)/mgnuc
> > -CFLAGS = -I$(RUNTIME_DIR) $(EXTRA_CFLAGS)
> > -# we need -I ../runtime for "getopt.h"
> > +MGNUC   =       MERCURY_C_INCL_DIR=$(RUNTIME_DIR) $(SCRIPTS_DIR)/mgnuc
> > +MGNUCFLAGS =    -I$(RUNTIME_DIR) $(EXTRA_CFLAGS)
> 
> You changed `CFLAGS' to `MGNUCFLAGS' here, but you didn't change all
> the uses of it.

Hmmm... Actually, that CFLAGS line shouldn't change at all, only the
MGNUC = ... change is really necessary. How does that sound?

-- 
       Tyson Dowd           # 4.4: People keep saying the behavior is undefined,
                            # but I just tried it on an ANSI-conforming compiler
     trd at cs.mu.oz.au        # and got the results I expected.
http://www.cs.mu.oz.au/~trd # A: They were wrong. Flame them mercilessly. C-IAQ



More information about the developers mailing list