[m-dev.] diff: missing #include

Fergus Henderson fjh at cs.mu.oz.au
Tue Jul 29 14:58:00 AEST 1997


Tyson Richard DOWD, you wrote:
> 
> util/mdemangle.c:
> 	Add #include <assert.h>.

That change looks fine, but your comment

> Don't release without this one.... ;-)

is quite convincing -- mdemangle.c already includes "std.h" which includes
<assert.h>, so this change should be for stylistic reasons (making things
self-contained) rather than for correctness.  Did I miss something?
How did you discover this one?

-- 
Fergus Henderson <fjh at cs.mu.oz.au>   |  "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh>   |  of excellence is a lethal habit"
PGP: finger fjh at 128.250.37.3         |     -- the last words of T. S. Garp.



More information about the developers mailing list