[m-dev.] diff: module qualification of labels

[Fergus Henderson]

Simon TAYLOR, you wrote:
> compiler/llds_out.m
> compiler/fact_table.m
> compiler/opt_debug.m
> 	Renamed llds_out__maybe_qualify_label to llds_out__qualify_label.
> 	llds_out__maybe_qualify_label didn't qualify the name if it was of 
> 	the form Module__Name. Now that we parse '__' as a module qualifier,
> 	it should always qualify the label.

The log message should make it clear that you changed the behaviour
of the pred, as well as renaming it.

Have you bootchecked this change?

llds_out.m:
> @@ -2196,9 +2196,9 @@
>  	% we need to qualify it with both the module name of the
>  	% type, and also (if it is different) the module name of the
>  	% current module.
> -	llds_out__maybe_qualify_name(MangledTypeModule, MangledTypeName,
> +	llds_out__qualify_name(MangledTypeModule, MangledTypeName,
>  		QualifiedMangledTypeName),
> -	llds_out__maybe_qualify_name(MangledModule, QualifiedMangledTypeName,
> +	llds_out__qualify_name(MangledModule, QualifiedMangledTypeName,
>  		FullyQualifiedMangledTypeName),

This code doesn't correct implement the comment anymore,
so either you have a bug in the code, or a bug in the comment.
I think the behaviour specified by the comment is better,
because the alternative leads to unnecessarily long symbol names
in the generated code.  So I consider this a bug in the code.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>   |  "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh>   |  of excellence is a lethal habit"
PGP: finger fjh at 128.250.37.3         |     -- the last words of T. S. Garp.