for review: changes to review procedures.

[Tyson Richard DOWD]

Hi,

Fergus, is it ok if I steal your subject lines like this?

===================================================================


Estimated hours taken: 0.3

Update the review procedures to reflect what we are doing now, which
seems to be working well.

compiler/notes/reviews.html:
	Add different subjects ("for review" "diff" and "trivial diff"
	for differnet classes of reviewing).
	Allow second round diffs to be committed before second review,
	if there were few problems at the first review.


Index: compiler/notes/reviews.html
===================================================================
RCS file: /home/staff/zs/imp/mercury/compiler/notes/reviews.html,v
retrieving revision 1.1
diff -u -r1.1 reviews.html
--- reviews.html	1997/04/03 05:17:53	1.1
+++ reviews.html	1997/12/03 04:36:04
@@ -46,8 +46,11 @@
 <li>  Write log message for this change - use template (see below).
 <li>  Review diff and log message yourself. (see below)
 <li>  Send to mercury-developers at cs.mu.oz.au, with the subject
-	    "cvs diff: <short description of change>".
+	    "for review: <short description of change>".
 	    Nominate a reviewer at top of diff (see below).
+	    (If this change has been reviewed once before, it might
+	    fall into the "commit before review" category -- see the
+	    section on exceptions).
 <li>  Wait for review (see below).
 <li>  Fix any changes suggested. 
 <li>  Repeat above steps until approval.
@@ -229,6 +232,17 @@
 
 <p>
 
+Usually, a change that has already been reviewed falls into this
+category, provided you have addressed the reviewers comments, and 
+there are no disputes over design decisions. If the reviewer has
+specifically asked for another review, or there were a large number of
+comments at the review, you should not commit before a second review.
+
+<p>
+
+If you are going to commit before the review, use the subject line:<br>
+	    "diff: <short description of change>".
+
 <h2> Exceptions: No review </h2>
 
 <p>
@@ -258,6 +272,11 @@
 		stuff reflects on the whole group, so it shouldn't be
 		ignored.
 </ul>
+
+If your change falls into this category, you should still send the
+diff and log message to mercury-developers, but use the subject line:<br>
+"trivial diff: <short description of change>".
+
 
 <hr>
 <!-------------------------->


-- 
       Tyson Dowd           # 
                            #         Linux versus Windows is a 
     trd at cs.mu.oz.au        #            Win lose situation.
http://www.cs.mu.oz.au/~trd #