[m-dev.] for review: tests for mdmangle

[Tyson Richard DOWD]

Thomas Charles CONWAY wrote:
> 
> tests/misc_tests/mdmangle.{inp,exp}:
> 	add a couple of tests for the mangling of lambda goal names

>  
> +	some lambda goals
> +<pred goal from 'simplex' line 262 label 5>
> +<func goal from 'collect_vars' line 153>
> Index: mdemangle_test.inp
> ===================================================================
> RCS file: /home/staff/zs/imp/tests/misc_tests/mdemangle_test.inp,v
> retrieving revision 1.6
> diff -u -r1.6 mdemangle_test.inp
> --- mdemangle_test.inp	1997/07/26 11:45:06	1.6
> +++ mdemangle_test.inp	1997/08/27 03:37:50
> @@ -84,3 +84,6 @@
>  mercury_data_foo
>  mercury_data_foo
>  
> +	some lambda goals
> +mercury__lp__IntroducedFrom__pred__simplex__262__9_7_0_i5
> +mercury__lp__IntroducedFrom__func__collect_vars__153__4_3_0
> cvs diff: Diffing .

This is not the normal format for mdemangle tests. 

There is a comment at the top of this file that says:

	A collection of symbols for use in testing mdemangle.

	Each symbol is followed by the correct decoding.

Although this isn't necessary for the test to be useful, it makes
interpreting errors a little easier. It also makes it easier for
future maintainers to see which symbols correspond with which decoding.

I think you should stick with the tradition, or else change the 
comment at the top, since currently it's wrong and possibly misleading.

-- 
       Tyson Dowd           #          Another great idea from the 
                            #            people who brought you
      trd at .cs.mu.oz.au      #               Beer Milkshakes!
http://www.cs.mu.oz.au/~trd #	         Confidence --- Red Dwarf