[m-dev.] Diff for review: bug fix in modecheck_unify

Fergus Henderson fjh at cs.mu.oz.au
Mon Apr 28 21:28:44 AEST 1997


Andrew Bromage, you wrote:
> 
> Fergus or Simon, could you review this one please?

That change looks fine, except for one thing: you should
keep the argument order consistent.

>  modecheck_unify_functor(X, TypeOfX, ConsId0, ArgVars0, Unification0,
> -			ExtraGoals, Mode, ArgVars, Unification,
> +			ExtraGoals, Mode, ArgVars, Unification, ConsId,
>  			ModeInfo0, ModeInfo) :-

If the input arguments use the order ConsId0, ArgVars0, Unification,
then the output arguments should use the order ConsId, ArgVars, Unification,
not ArgVars, Unification, ConsId.

Can you please fix that and then commit the change?

-- 
Fergus Henderson <fjh at cs.mu.oz.au>   |  "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh>   |  of excellence is a lethal habit"
PGP: finger fjh at 128.250.37.3         |     -- the last words of T. S. Garp.



More information about the developers mailing list