[m-dev.] cvs diff: argument/3, det_argument/3

[Fergus Henderson]

Tyson Richard DOWD, you wrote:

> 	Fergus, could you review this please?

Sure.

> +	% argument(Date, ArgumentIndex, Argument)

s/Date/Data/

> +	% Given a data item (Data) and an argument index
> +	% (ArgumentIndex), starting at 0 for the first argument, binds
> +	% Argument to that argument of the functor of the data item. If
> +	% the argument index is out of range - that is greater than or
> +	% equal to the arity of the functor or lower than 0, argument/3

I suggest the following minor changes to the last two lines above:

> +	% the argument index is out of range -- that is greater than or
> +	% equal to the arity of the functor, or lower than 0 -- argument/3

> +arg(ArgumentIndex, Type, Argument) :-
> +	argument(Type, ArgumentIndex, Argument).
> +
>  det_arg(ArgumentIndex, Type, Argument) :-
> +	det_argument(Type, ArgumentIndex, Argument).

You forgot to subtract one.

Otherwise that looks good, please make the above changes and then commit it.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>   |  "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh>   |  of excellence is a lethal habit"
PGP: finger fjh at 128.250.37.3         |     -- the last words of T. S. Garp.